Exposed types for doc, ppt and xls files #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated mimetypes, utis and extensions to include doc, powerpoint and excel types. Now the types above can be accessed through ocumentPicker.types.*
vonovak
requested changes
Oct 5, 2020
|
thanks for the PR! |
DomiR
added a commit
to DomiR/react-native-document-picker
that referenced
this pull request
Nov 21, 2020
* upstream/master: 4.1.0 feat: Exposed types for doc, ppt and xls files (react-native-documents#348) 4.0.0 Fix React dependency to enable XCode 12 build (react-native-documents#347)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated mimetypes, utis and extensions to include doc, powerpoint and excel types.
Now the types above can be accessed through DocumentPicker.types.*
This changes were previously proposed by imbudhiraja in this pull request. I changed some uniform type identifiers for IOS based on this refference. This solution seems to work for me on an existing project.
(I also reordered some of the types to maintain alphabetical organization).