Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent synopsis for "install all" and "install components" scripts #14

Closed
skalee opened this issue Nov 6, 2018 · 3 comments
Closed

Comments

@skalee
Copy link
Contributor

skalee commented Nov 6, 2018

The install_gpg_all.sh script requires passing suite version with -i argument.
The install_gpg_component.sh script requires passing component version with --version argument.

  1. This inconsistency should be resolved.
  2. --version is a bad name for argument, because <program> --version conventionally prints out program version. Perhaps --at-version or --at?

@ronaldtse, any idea what -i could mean? It has been introduced in your commit.

@ronaldtse
Copy link
Contributor

Sorry, I don’t actually remember. I wonder if it stood for “install” 😢

—at is definitely better than —version.

@skalee
Copy link
Contributor Author

skalee commented Nov 19, 2018

I believe this one can be considered fixed as of #17.

@skalee skalee closed this as completed Nov 19, 2018
@ronaldtse
Copy link
Contributor

Thanks @skalee !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants