[🐛 BUG]: http: superfluous response.WriteHeader

[mfadul24]

No duplicates 🥲.

• I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?

The ready and status endpoint are flooding the logs on the Kubernetes Cluster with entries like:

http: superfluous response.WriteHeader call from github.com/roadrunner-server/status/v4.(*Health).ServeHTTP (health.go:72)

http: superfluous response.WriteHeader call from github.com/roadrunner-server/status/v4.(*Health).ServeHTTP (ready.go:77)

Version (rr --version)

2023.1.0

How to reproduce the issue?

Activate status endopoint:

status:
  address: '0.0.0.0:2114'

and use it on kubernetes:

          livenessProbe:
            httpGet:
              path: /health?plugin=http
              port: php-status
            initialDelaySeconds: 10
            periodSeconds: 5

Relevant log output

: superfluous response.WriteHeader call from github.com/roadrunner-server/status/v4.(*Health).ServeHTTP (health.go:72)

```http: superfluous response.WriteHeader call from github.com/roadrunner-server/status/v4.(*Health).ServeHTTP (ready.go:77)```

[joaopbnogueira]

Just a heads up that we're facing the same issue after the update (today) to 2023.01 also in K8s

  livenessProbe:
    httpGet:
      path: /health?plugin=http
      port: 2114

[rustatian]

Got u guys, this is because Go does not allow to write twice to the Write or Headers methods. I'll fix this and release a bugfix this Thursday, as we normally do. Thanks for contribution ❤️