Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🧹 CHORE]: Possible typo in AMQP-driver property named multiple_ack #1565

Closed
1 task done
Kaspiman opened this issue May 19, 2023 · 3 comments · Fixed by roadrunner-server/amqp#71
Closed
1 task done
Assignees
Labels
B-regression Bug: regression bugs C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Milestone

Comments

@Kaspiman
Copy link

Kaspiman commented May 19, 2023

No duplicates 🥲.

  • I have searched for a similar issue.

What should be improved or cleaned up?

Let's find the multiple_ack param - there are no results.

Let's find the "multiple_ask" roadrunner-server/amqp - i found mapping multiple_ask => MultipleAck.

But in AMQP config we have only multiple_ack param.


Additional: check the tests: https://github.com/roadrunner-server/rr-e2e-tests/blob/master/plugins/jobs/amqp/jobs_amqp_test.go

@Kaspiman Kaspiman added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label May 19, 2023
@rustatian
Copy link
Member

rustatian commented May 19, 2023

Hey @embargo2710 👋🏻
Yeah, this is def typo. Will fix that, thanks 👍🏻

@github-project-automation github-project-automation bot moved this to Backlog in General May 19, 2023
@rustatian rustatian added this to the v2023.1.4 milestone May 19, 2023
@rustatian rustatian moved this from Backlog to Todo in General May 19, 2023
@rustatian rustatian added the B-regression Bug: regression bugs label May 19, 2023
@rustatian rustatian moved this from Todo to In Progress in General May 19, 2023
@Kaspiman
Copy link
Author

Kaspiman commented May 19, 2023

@rustatian
Since we met in this issue, can you add a more understandable description for the "multiple_ack" parameter?

multiple_ack - this delivery, along with all prior unacknowledged deliveries on the same channel, will be acknowledged. This feature is beneficial for batch processing of deliveries and is applicable only for Ack, not for Nack.

what is the "this delivery" and what could heapen when multiple_ack is true? At what moment of Jobs/task lifecycle can this happen?

@rustatian
Copy link
Member

Delivery is the messages that are delivered through the queue. This is the default rabbitmq term. Communication with the rabbitmq broker is done through the channels. So, for example, if you have the 10 messages that are being processed by the workers, and you use multiple_ack=true, then when the first message (JOB) is processed, it'll auto-acknowledge all the previous messages (Deliveries): https://www.rabbitmq.com/confirms.html#consumer-acks-multiple-parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-regression Bug: regression bugs C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants