Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some docs and correct improve error print #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

napoleon665
Copy link
Contributor

When running exchange executable in a docker container we get:

panic: route ip+net: no such network interface

goroutine 1 [running]:
github.com/robaho/go-trader/internal/exchange.startMarketData()
        /app/internal/exchange/marketdata.go:261 +0x336
github.com/robaho/go-trader/internal/exchange.(*exchange).Start(...)
        /app/internal/exchange/exchange.go:284
main.main()
        /app/cmd/exchange/main.go:69 +0x517

This is due to lo0 not being available.

@@ -257,7 +257,7 @@ func startMarketData() {
}
_intf, err := net.InterfaceByName(intf)
if err != nil {
panic("unable to read multicast interface")
panic(err)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be better as:

panic(fmt.Errorf("unable to find multicast interface %q: %w",intf,err))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants