Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private methods and private fields separation #79

Closed
jonathanKingston opened this issue Jul 10, 2023 · 2 comments · Fixed by #87
Closed

Private methods and private fields separation #79

jonathanKingston opened this issue Jul 10, 2023 · 2 comments · Fixed by #87
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@jonathanKingston
Copy link

Currently it appears there is not ability to disambiguate between class fields and class methods (please correct me if I'm wrong).

Rationale

@robatwilliams
Copy link
Owner

The plugin is using https://eslint-community.github.io/eslint-plugin-es-x/rules/no-class-fields.html whose scope includes methods and fields (full list seen in their test source).

In my join-up of that rule with compat DB features, I have only referred to fields - which is a bug.

To enable distinguishing, the es-x plugin's rule would need splitting, or a custom one written here. I can't see them splitting it for this use case.

@robatwilliams robatwilliams added bug Something isn't working enhancement New feature or request labels Jul 10, 2023
@robatwilliams robatwilliams changed the title Consider support of separation of private methods from private fields Private methods and private fields separation Jul 10, 2023
@robatwilliams
Copy link
Owner

Bug part of this needs fixing, but the enhancement won't be due to limitation of no-class-fields as described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants