From 0b12cc84218d8cbe8b2ee1d4064f94d41ea61378 Mon Sep 17 00:00:00 2001 From: Thomas Hauk Date: Tue, 12 Mar 2013 13:29:19 -0700 Subject: [PATCH 1/2] Enable "Suspicious Implicit Conversions" warning and fix occurances --- KissXML/DDXMLElement.m | 8 ++++---- UnitTesting/KissXML.xcodeproj/project.pbxproj | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/KissXML/DDXMLElement.m b/KissXML/DDXMLElement.m index a8cae781..bf00b99c 100644 --- a/KissXML/DDXMLElement.m +++ b/KissXML/DDXMLElement.m @@ -156,17 +156,17 @@ - (NSArray *)_elementsForName:(NSString *)name if (uri == nil) { - match = xmlStrEqual(child->name, xmlName); + match = (BOOL)xmlStrEqual(child->name, xmlName); } else { - BOOL nameMatch = xmlStrEqual(child->name, xmlName); - BOOL localNameMatch = xmlStrEqual(child->name, xmlLocalName); + BOOL nameMatch = (BOOL)xmlStrEqual(child->name, xmlName); + BOOL localNameMatch = (BOOL)xmlStrEqual(child->name, xmlLocalName); BOOL uriMatch = NO; if (child->ns) { - uriMatch = xmlStrEqual(child->ns->href, xmlUri); + uriMatch = (BOOL)xmlStrEqual(child->ns->href, xmlUri); } if (hasPrefix) diff --git a/UnitTesting/KissXML.xcodeproj/project.pbxproj b/UnitTesting/KissXML.xcodeproj/project.pbxproj index 8846ed97..6f4e2abd 100644 --- a/UnitTesting/KissXML.xcodeproj/project.pbxproj +++ b/UnitTesting/KissXML.xcodeproj/project.pbxproj @@ -312,6 +312,7 @@ isa = XCBuildConfiguration; buildSettings = { ARCHS = "$(ARCHS_STANDARD_32_64_BIT)"; + CLANG_WARN_SUSPICIOUS_IMPLICIT_CONVERSION = YES; GCC_C_LANGUAGE_STANDARD = c99; GCC_OPTIMIZATION_LEVEL = 0; GCC_WARN_ABOUT_RETURN_TYPE = YES; @@ -327,6 +328,7 @@ isa = XCBuildConfiguration; buildSettings = { ARCHS = "$(ARCHS_STANDARD_32_64_BIT)"; + CLANG_WARN_SUSPICIOUS_IMPLICIT_CONVERSION = YES; GCC_C_LANGUAGE_STANDARD = c99; GCC_WARN_ABOUT_RETURN_TYPE = YES; GCC_WARN_UNUSED_VARIABLE = YES; From 3905c2e23f80aadc4ebd5caa15dda54ad73a03d1 Mon Sep 17 00:00:00 2001 From: Thomas Hauk Date: Tue, 12 Mar 2013 13:29:46 -0700 Subject: [PATCH 2/2] Enable "Hidden Local Variable" warning and fix occurance --- KissXML/DDXMLElement.m | 1 - UnitTesting/KissXML.xcodeproj/project.pbxproj | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/KissXML/DDXMLElement.m b/KissXML/DDXMLElement.m index bf00b99c..75959de6 100644 --- a/KissXML/DDXMLElement.m +++ b/KissXML/DDXMLElement.m @@ -250,7 +250,6 @@ - (NSArray *)elementsForLocalName:(NSString *)localName URI:(NSString *)uri } else { - NSString *prefix; NSString *realLocalName; [DDXMLNode getPrefix:&prefix localName:&realLocalName forName:localName]; diff --git a/UnitTesting/KissXML.xcodeproj/project.pbxproj b/UnitTesting/KissXML.xcodeproj/project.pbxproj index 6f4e2abd..d7159620 100644 --- a/UnitTesting/KissXML.xcodeproj/project.pbxproj +++ b/UnitTesting/KissXML.xcodeproj/project.pbxproj @@ -316,6 +316,7 @@ GCC_C_LANGUAGE_STANDARD = c99; GCC_OPTIMIZATION_LEVEL = 0; GCC_WARN_ABOUT_RETURN_TYPE = YES; + GCC_WARN_SHADOW = YES; GCC_WARN_UNUSED_VARIABLE = YES; HEADER_SEARCH_PATHS = /usr/include/libxml2; MACOSX_DEPLOYMENT_TARGET = 10.6; @@ -331,6 +332,7 @@ CLANG_WARN_SUSPICIOUS_IMPLICIT_CONVERSION = YES; GCC_C_LANGUAGE_STANDARD = c99; GCC_WARN_ABOUT_RETURN_TYPE = YES; + GCC_WARN_SHADOW = YES; GCC_WARN_UNUSED_VARIABLE = YES; HEADER_SEARCH_PATHS = /usr/include/libxml2; MACOSX_DEPLOYMENT_TARGET = 10.6;