Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift Package Manager support #1176

Closed
karimhm opened this issue Jul 27, 2020 · 5 comments · Fixed by #1177
Closed

Add Swift Package Manager support #1176

karimhm opened this issue Jul 27, 2020 · 5 comments · Fixed by #1177

Comments

@karimhm
Copy link
Contributor

karimhm commented Jul 27, 2020

Related to #1149

The following PRs need to be merged first before being able to add a Package.swift manifest to XMPPFramework

  • KissXML: #119
  • libidn-framework: #6
@chrisballinger
Copy link
Collaborator

This is also blocked on Xcode 12 because XMPPFramework includes resources, which requires SPM 5.3. See SE-0271 for more details.

ss.resources = [ 'Extensions/**/*.{xcdatamodel,xcdatamodeld}']

@karimhm
Copy link
Contributor Author

karimhm commented Jul 27, 2020

This is also blocked on Xcode 12 because XMPPFramework includes resources, which requires SPM 5.3. See SE-0271 for more details.

ss.resources = [ 'Extensions/**/*.{xcdatamodel,xcdatamodeld}']

We could add Swift PM support but let the user to copy all assets needed by XMPPFramework, until Xcode 12 rolls out to production.

@karimhm
Copy link
Contributor Author

karimhm commented Jul 27, 2020

@chrisballinger I believe it is possible to use XMPPFramework without Core Data extensions (but nothing will persist).

@karimhm
Copy link
Contributor Author

karimhm commented Jul 28, 2020

@chrisballinger is it ok to migrate the Core Data object model from xcdatamodel bundle to code?

@chrisballinger
Copy link
Collaborator

@karimhm It would probably be better to leave the model definitions as-is to avoid breaking changes if possible. Really appreciate your work on the SPM support, it's been on my mind for a while and you did an awesome job getting all the pieces in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants