-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List timeline filter #507
List timeline filter #507
Conversation
lib/components/common/timeline/list_timeline/cubit/list_timeline_cubit.dart
Show resolved
Hide resolved
icon: cubit.filter != TimelineFilter.empty | ||
? Icon(Icons.filter_alt, color: theme.colorScheme.primary) | ||
: const Icon(Icons.filter_alt_outlined), | ||
onTap: Scaffold.of(context).openEndDrawer, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just remembered why I haven't added the list timeline filter yet - this doesn't work when you have a list timeline in your home screen since the end drawer in the home screen contains the home timeline drawer.
There is no easy fix for it since the home screen scaffold lives above the home tab view so we can't change out the end drawer while we are on a different tab.
We can still merge it to master but I will wait for #341 until releasing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see what you mean. If only there were a way to dynamically swap which content is displayed in the endDrawer based on its context. i.e. context.widget is HomeTimeline ? ListTimelineFilterDrawer() : HomeTimelineFilterDrawer()
😕
Here's a new feature added to allow users to filter list timelines similar to the Home Screen. I hope you like it 🙂
Closes #352
Partially closes #341 (Add filters for lists)
screen-20211227-083304_3.mp4