From f114ad0d26d445b5d154cff7c59ae39163e83390 Mon Sep 17 00:00:00 2001 From: Rob Hogan Date: Sat, 18 Feb 2023 11:43:23 -0800 Subject: [PATCH] Remove `.node-version` file from repo root and template Summary: IMO, there's no value in having `.node-version` files either in the repository or the template. I don't believe it's standard practice, the support from tooling is patchy (at least `nvm` [ignores it](https://github.com/nvm-sh/nvm/issues/794), and Node is often used without a version manager), and it's unnecessarily restrictive when it is actually enforced. In every other case, it's potentially misleading noise. Libraries should use `package.json#engines` to specify their Node JS compatibility ranges, as indeed `react-native` [already does](https://github.com/facebook/react-native/blob/1629b9f0a11f42ff12c6dd06a20afb80067e4958/package.json#L10). React Native users may wish to add one to their own projects according to their own setup or team, but we shouldn't confuse the issue by including an arbitrary one in the template. Changelog: [General][Removed] Remove `.node_version` from app template. Differential Revision: D43421085 fbshipit-source-id: 37558ef3aee6479b40746cccf83beb1577473786 --- .node-version | 1 - template/_node-version | 1 - 2 files changed, 2 deletions(-) delete mode 100644 .node-version delete mode 100644 template/_node-version diff --git a/.node-version b/.node-version deleted file mode 100644 index 3c032078a4a21c..00000000000000 --- a/.node-version +++ /dev/null @@ -1 +0,0 @@ -18 diff --git a/template/_node-version b/template/_node-version deleted file mode 100644 index 3c032078a4a21c..00000000000000 --- a/template/_node-version +++ /dev/null @@ -1 +0,0 @@ -18