Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: no fela styles on saved page #915

Closed
d9k opened this issue Oct 10, 2023 · 1 comment
Closed

Bug: no fela styles on saved page #915

d9k opened this issue Oct 10, 2023 · 1 comment

Comments

@d9k
Copy link

d9k commented Oct 10, 2023

I see that #825 removes rendering <style> tag content (textContent) on devMode.
( packages/fela-dom/src/dom/connection/insertRuleInDevMode.js file was deleted)

But there is a bug: If in the Chrome browser I save webpage (Ctrl+S) which uses fela and then reopen it later (Ctrl-O) there are no fela syles applied to the webpage elements!

I tried to downgrade fela to the version 11.4.0 before #825, enabled devMode: true in fela renderer config, saved page again, reopened it and the style were there, visible.

So I propose to add flag updateStyleTagTextContent as was suggested in #544

@d9k
Copy link
Author

d9k commented Oct 14, 2023

Have errors like

 Prop `className` did not match. Server: "fela_a fela_b fela_c fela_d" Client: "fela_a fela_b fela_e fela_d"

With fela-dom 11.4.0 and SSR 😠

So downgrade doesn't suit as temporary solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants