Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contribution] how-to-track-and-count-vehicles-with-yolov8.ipynb updated with latest Supervision 0.13.0 API #189

Closed
grhaonan opened this issue Aug 27, 2023 · 4 comments · Fixed by #190
Assignees
Labels
enhancement New feature or request

Comments

@grhaonan
Copy link
Contributor

Hi team,

Thanks for your awesome work on the Supervison, it is fantastic!

I tried to follow your notebook at:
https://github.com/roboflow/notebooks/blob/main/notebooks/how-to-track-and-count-vehicles-with-yolov8.ipynb
to get my head around how to do the tracking and counting with Supervision but found it is quite out of date.

Fortunately, your documentation is clear to follow so I refactored the notebook with the latest API (0.13.0) and there are quite a few changes compared with your original version. Main changes:

  • Removing section "ByteTrack"
  • Removing section "Tracking utils"
  • Refactoring all necessary Classes or methods, such as LineCounter to LineZone, LineCounterAnnotator to LineZoneAnnotator plot_image etc
  • Replace video loop by VideoSink to process_video

I am happy to share it so the whole community can benefit from my work but I understand you may would like to keep it as it is as the API is not stable yet.

In case you are interested and would like me to make this contribution, there are two options you may like to proceed?

Option 1: I submit a PR to replace the original notebook

Option 2: I submit a PR to add my version with a specific file name (let me know your preferred naming convention) so it is clear that this new notebook is for Supervision 0.13.0.

Option 3: No action

Option 4: ?

The refactored version for your review: https://colab.research.google.com/drive/11Enps_V9D3Bd7UVAFuCtV2DGkyiPYJVp?usp=sharing

Again, thanks for your great work on Supervision, we are excited!

@github-actions
Copy link

👋 Hello @grhaonan, thank you for leaving an issue on Roboflow Notebooks.

🐞 Bug reports

If you are filing a bug report, please be as detailed as possible. This will help us more easily diagnose and resolve the problem you are facing. To learn more about contributing, check out our Contributing Guidelines.

If you require support with custom code that is not part of Roboflow Notebooks, please reach out on the Roboflow Forum or on the GitHub Discussions page associated with this repository.

💬 Get in touch

Do you have more questions about Roboflow that we haven't responded to yet? Feel free to ask them on the Roboflow Discuss forum. Our developer advocates and community team actively respond to questions there.

To ask questions about Notebooks, head over to the GitHub Discussions section of this repository.

@SkalskiP
Copy link
Collaborator

Hi, @grhaonan! 👋🏻! This is awesome. The fact that the old ByteTrack notebook and Supervision library have inspired you to this extent makes me very happy. We are adding it to the repo!

We should keep both old and new versions of the notebook. We can't replace the old one as it relates to our YouTube video. Here is my plan:

  • Open PR with your updated notebook.
  • Link a new notebook to an old notebook.

What do you think? :)

@SkalskiP SkalskiP added the enhancement New feature or request label Aug 28, 2023
@grhaonan
Copy link
Contributor Author

@SkalskiP cool, cool, thanks for your quick reply and I am fine with your plan.

I am not 100% sure if I understand your plan, but I have submitted a PR (#190) to upload this new notebook under notebooks folder.

Option 1: you would like to link the new notebook only instead of having a physical copy under notebooks -> then please reject my PR and I will update the original notebook with a link to my colab address -> send a new PR

Option 2: you would like to have both a phycial copy and a new link -> I can then send another PR with a link added in the original notebook pointing to this phycial copy under notebooks folder once you merge #190

@SkalskiP
Copy link
Collaborator

Hi, @grhaonan 👋🏻 Good! Let's move the conversation to your PR. To have everything in one place.

@SkalskiP SkalskiP linked a pull request Aug 29, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants