Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting LineZoneAnnotator to display per-class counts in annotations #836

Closed
wants to merge 2 commits into from

Conversation

RaghavvGupta
Copy link
Contributor

@RaghavvGupta RaghavvGupta commented Feb 1, 2024

Adjusting LineZoneAnnotator to display per-class counts in annotations #790

Description

Introduced per-class counts for objects crossing the line. Updated the trigger method to handle per-class counts.

Type of change

class_in_count (Dict[int, int]): A dictionary to store per-class in counts.
class_out_count (Dict[int, int]): A dictionary to store per-class out counts.
These dictionaries will store counts for each class separately.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

@LinasKo
Copy link
Collaborator

LinasKo commented Oct 1, 2024

Hi @RaghavvGupta 👋

Thank you for your contribution, and apologies for the long wait.

Your solution fits the original specification (except for tests on Colab), but there were a few flaws and we had no time to give feedback. Briefly:

  1. This removed the prior in_count and out_count variables which might break existing code
  2. This creates new behaviour for the existing annotator, without providing a way to access old annotation style.
  3. There's no Colab with tests.

It turned out a more complicated change than we expected, but the implementation is on #1555.

I'll close this one, but you have my sincerest thanks for the effort put in! 🙏

@LinasKo LinasKo closed this Oct 1, 2024
@RaghavvGupta
Copy link
Contributor Author

Hi @LinasKo, Thanks for your feedback! I have understood the implementation and sincerely apologise for not being able to deliver the requisite. However, I learned a lot from this!
Thanks again for giving me this opportunity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants