Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use pcg_rand 0.9.2 without nightly #9

Closed
kennytm opened this issue Oct 13, 2018 · 2 comments
Closed

Cannot use pcg_rand 0.9.2 without nightly #9

kennytm opened this issue Oct 13, 2018 · 2 comments

Comments

@kennytm
Copy link

kennytm commented Oct 13, 2018

886f854 added a #![feature(tool_lints)] which requires nightly to work, making it not possible to use 0.9.2 on beta or stable

#![feature(tool_lints)]

The tool_lints warning has been canceled by rust-lang/rust#54358 on the current 1.30 beta channel, so writing #[allow(needless_pass_by_value)] should be fine.

BTW, the feature has been stabilized by rust-lang/rust#54870 on the current 1.31 nightly channel meaning you don't need #![feature(tool_lints)] to write #[allow(clippy::needless_pass_by_value)] either.

@robojeb
Copy link
Owner

robojeb commented Oct 16, 2018

That is my bad, I should learn to check against all (or more) supported rust versions.

I have published 0.9.3 which should resolve this, it also moves u128 support behind a default feature (in case people don't need/want it) and adds very early experimental serde support.

@robojeb
Copy link
Owner

robojeb commented Oct 16, 2018

The new version is published and should resolve this.
Let me know if anything else is broken, ill do my best to fix it.

@robojeb robojeb closed this as completed Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants