Bump rules_java to 8.6.0 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
reviewed
Dec 3, 2024
| # consider using the protobuf_deps() public API from @com_google_protobuf//:protobuf_deps.bzl | ||
| load("@com_google_protobuf//bazel/private:proto_bazel_features.bzl", "proto_bazel_features") # buildifier: disable=bzl-visibility | ||
|
|
||
| proto_bazel_features(name = "proto_bazel_features") |
There was a problem hiding this comment.
Are users on the consuming side of these rules going to do this as well?
There was a problem hiding this comment.
WORKSPACE users will have to copy paste this whole part into their WORKSPACE at minimum. If they actually need the whole protobuf setup, they'll need to invoke @com_google_protobuf//:protobuf_deps.bzl.
The WORKSPACE setup for a bunch of repositories (including rules_android) will get more complicated as we creep towards Bazel 8 unfortunately.
Bencodes
approved these changes
Dec 3, 2024
|
btw, could we possibly roll this into a 4.11.1.2 release? Sorry for the churn, I realize that the .1 release just went out yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the newer rules_java version, we no longer need the http_jar.bzl hack.