From fcb75fa85110be8a6786fb10e04723b7ab192424 Mon Sep 17 00:00:00 2001 From: Yusuke KUOKA Date: Wed, 22 Aug 2018 18:57:01 +0900 Subject: [PATCH] fix: Make logging on unmatched selectors less verbose Fixes #200 --- state/state.go | 3 ++- state/state_test.go | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/state/state.go b/state/state.go index 77861123..953b4cc0 100644 --- a/state/state.go +++ b/state/state.go @@ -607,7 +607,8 @@ func (state *HelmState) FilterReleases(labels []string) error { filteredReleases = append(filteredReleases, r) } if len(filteredReleases) == 0 { - return fmt.Errorf("specified selector did not match any releases in %s\n", state.file) + state.logger.Debugf("specified selector did not match any releases in %s\n", state.file) + return nil } state.Releases = filteredReleases return nil diff --git a/state/state_test.go b/state/state_test.go index 63795ee0..5cc4253b 100644 --- a/state/state_test.go +++ b/state/state_test.go @@ -861,18 +861,19 @@ func TestHelmState_NoReleaseMatched(t *testing.T) { { name: "name does not exist", labels: "name=releaseB", - wantErr: true, + wantErr: false, }, { name: "label does not match anything", labels: "foo=notbar", - wantErr: true, + wantErr: false, }, } for _, tt := range tests { i := func(t *testing.T) { state := &HelmState{ Releases: releases, + logger: logger, } errs := state.FilterReleases([]string{tt.labels}) if (errs != nil) != tt.wantErr {