Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change the delimiters for state templates and release templates #658

Open
mumoshu opened this issue Jun 6, 2019 · 1 comment
Open

Comments

@mumoshu
Copy link
Collaborator

mumoshu commented Jun 6, 2019

As @sebastien-prudhomme suggested in #515:

I've just discovered the edge case for Prometheus AlertManager and was surprised by the fact that helmfile.yaml is a template.

It seems that it's possible to change the curly bracket separator with other separator. Have you considered that option?

After quick thinking I have following options:

  • s{ ... } for state templates
  • r{ ... }
  • Set HELMFILE_EXPERIMENTAL to require .gotmpl file ext.(.gotmpl should be required to enable templating of helmfile.yaml #584) to enable the new delimiters while disabling the old delimiters. Maybe the behavior of HELMFILE_EXPERIMENTAL will be the default in near future. But this allows us to keep backward-compatibility for a while anyway.

Any thoughts?

@mumoshu
Copy link
Collaborator Author

mumoshu commented Jun 18, 2019

Neither s{ } nor r{ } seem to work in cases like s{ {{.Foo.Bar}} } as the first } seen in Bar}} is considered the closing curly bracket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant