Update EoMotionControl to support the new velocityThres parameter #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattacini
approved these changes
Aug 29, 2023
This was referenced Aug 29, 2023
marcoaccame
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
seems fine by me.
NOTE: this PR belongs to the following group
- Update EoMotionControl to support the new velocityThres parameter #86
- Add velocityThres parameter for friction compensation icub-firmware#410
- Update eomcParser and embObjMotionControl to support the new velocityThresh param icub-main#903
- amc v108.9 + ems v3.73 + mc2plus v3.55 + mc4plus v3.76 icub-firmware-build#100
|
Let's wait for the distro 2023.08 to be released, before merging. |
sgiraz
force-pushed
the
devel
branch
2 times, most recently
from
e6ab2f9 to
641279d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new:
eOmc_motor_params_tstructure has been extended with the newvelocityThres- thebemf_valueandbemf_scaleparams have been removed from theeOmc_motor_params_tas they will not be used