-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime configuration of mtb4
/ mtb4c
boards to manage ergoCub
hand (5 fingers + palm)
#530
Runtime configuration of mtb4
/ mtb4c
boards to manage ergoCub
hand (5 fingers + palm)
#530
Conversation
… I2C triangles + palm mapping
I'm going to improve commented out relics etc and will do one more commit @marcoaccame |
ok @simeonedussoni thanks. I will write you some hints in the following. |
emBODY/eBcode/arch-arm/board/mtb4/application/src/main-appcan.cpp
Outdated
Show resolved
Hide resolved
emBODY/eBcode/arch-arm/board/mtb4c/application/src/main-appcan.cpp
Outdated
Show resolved
Hide resolved
emBODY/eBcode/arch-arm/embot/app/embot_app_application_theSkin.cpp
Outdated
Show resolved
Hide resolved
emBODY/eBcode/arch-arm/embot/app/embot_app_application_theSkin.cpp
Outdated
Show resolved
Hide resolved
emBODY/eBcode/arch-arm/embot/app/embot_app_application_theSkin.cpp
Outdated
Show resolved
Hide resolved
emBODY/eBcode/arch-arm/embot/app/embot_app_application_theSkin.cpp
Outdated
Show resolved
Hide resolved
emBODY/eBcode/arch-arm/embot/app/embot_app_application_theSkin.cpp
Outdated
Show resolved
Hide resolved
emBODY/eBcode/arch-arm/embot/app/embot_app_application_theSkin.cpp
Outdated
Show resolved
Hide resolved
emBODY/eBcode/arch-arm/embot/prot/can/embot_prot_can_analog_polling.cpp
Outdated
Show resolved
Hide resolved
@marcoaccame I thank you for the effort, but it's a llittle confusing for me since I'm already correcting/amending'/improving the items you highlighted, and having the comments distracts me from running smoothly... |
emBODY/eBcode/arch-arm/embot/prot/can/embot_prot_can_analog_polling.h
Outdated
Show resolved
Hide resolved
ok, I stopped |
in commit 8ae1ea4 I implemented all the above and some minor corrections needed from the previous PR with the same board involved. |
…ntype can be higher than 7
…gy#510 we can safely use the latest armclang compiler version
Hi @simeonedussoni, great! I will add a few changes to this PR and in particular:
|
mtb4
/ mtb4c
boards to manage ergoCub
hand (5 fingers + palm)
…iangles ID of the skin are mapped to the actual I2C hw
I have also improved the document about CAN protocol of the sensor boards to clarify how to use the |
In short
as per several discussions with @marcoaccame this PR contains the updated fw for the MTB4/c FW that allows to runtime switch the mapping between conventional and reshuffled mapping allowing to read out the ergoCubhand complete with palm in a back compatible fashion. the configuration is triggered when the MTB4/c receivess
skinType = 3
command.Full description
This PR allows to use the
mtb4
/mtb4c
board to manage all skin types in our robots.The configurability of the skin type is done through the parameter
SKIN_SET_BRD_CFG.skinType
inside the CAN protocol messageSKIN_SET_BRD_CFG
.Traditional skin patches
For traditional skin patches nothing changes and we can use the usual values of
SKIN_SET_BRD_CFG.skinType
plus the configuration of the triangles as usual.This PR improve the document describing the CAN protocol of the sensor boards by clarifying how the triangles inside a skin patch are mapped to the actual HW in terms of the pair (I2C bus, I2C adr).
The skin patch on the
ergoCub
handOn the
ergoCub
hand we have one triangle for each of the five fingertips and four triangles in the palm.We also wanted that each fingertip maintains the same I2C address so that we can easily change across the five fingers. That has required two things:
mtb4
andmtb4c
;We did the former in a previous PR:
mtb4
andmtb4c
: skin on the 5-th finger finally supported #509We have done the latter in here by:
SKIN_SET_BRD_CFG.skinType
: theMessage_SKIN_SET_BRD_CFG::SkinType::ergoHand
that is equal to 3.How to use the skin of ergoCub
To use the skin of the
ergoCub
hand is necessary to:mtb4
andmtb4c
w/ a PR scheduled soon;It will be enough:
Tests an mergeability
Extensive test we done on a dedicated setup for reading the skin of the palm and also for backwards compatibility w/ the standard patches.
I believe that we can safely merge.
Associated PRs
This PR: