FirmwareUpdater - configurable IPs #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding configurable ip address * wip * changing subnet tested - wip * small fix * fixed use of default ip * EthMaintanier - possible to set a board IP to 10.X.X.X * EthMaintanier - removed debug print
|
|
pattacini
changed the title
pattacini
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Fine with me as we've tested it.
Probably, it's also worth awaiting @marcoaccame 's review.
Nicogene
approved these changes
Sep 8, 2020
I just added the message if the default ip is overwritten by the one in the config file; I think it is usefull... |
This comment has been minimized.
This comment has been minimized.
pattacini
changed the title
pattacini
changed the title
This was referenced Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows configuring the IP's of the EMS boards through the
FirmwareUpdateras per the request in robotology/community#423.