added CLI option to FirmwareUpdater #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding CLI option to load .dat calibration file for strain2 * - added CLI option and method scheleton * loading calibration file to STRAIN2 eeprom works using SOCKETCAN device - wip * loading calibration file to STRAIN2 eeprom works using ETH device * added check on CAN line number - minor fixes * added check if CAN boardtype is STRAIN2 - minor fixes
pattacini
requested changes
Sep 22, 2020
There was a problem hiding this comment.
LGTM 👍🏻
Anyway, @davidetome could you please remove the //tumme comments?
We can rely on the blaming mechanism of GitHub to catch who did what 😉
sure @pattacini I missed to do that |
|
@pattacini comments removed |
pattacini
approved these changes
Sep 22, 2020
pattacini
changed the title
This was referenced Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding CLI option to load .dat calibration file for strain2
loading calibration file to STRAIN2 eeprom works using SOCKETCAN device - wip
loading calibration file to STRAIN2 eeprom works using ETH device
added check on CAN line number - minor fixes
added check if CAN boardtype is STRAIN2 - minor fixes