Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gravityCompensator: fix crash due to a move operator after a resize #702

Merged
merged 4 commits into from
Dec 10, 2020
Merged

gravityCompensator: fix crash due to a move operator after a resize #702

merged 4 commits into from
Dec 10, 2020

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Dec 10, 2020 •
edited by pattacini
Loading

It needs more investigations, but for now this make gravityCompensator works as expected.

TO BE TESTED on the robot (cc @violadelbono @julijenv )

@Nicogene Nicogene requested a review from pattacini December 10, 2020 14:51
@Nicogene Nicogene self-assigned this Dec 10, 2020
@Nicogene
Copy link
Member Author

Sorry wrong base branch, closing and reopening with the right base branch

@Nicogene Nicogene closed this Dec 10, 2020
@pattacini pattacini reopened this Dec 10, 2020
@pattacini pattacini changed the base branch from master to v1.17.1 December 10, 2020 15:11
pattacini
pattacini requested changes Dec 10, 2020
View reviewed changes
Copy link
Member

@pattacini pattacini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nicogene for the fix 👍🏻

Could you please polish the changes in order to retain only the relevant fix and remove the formatting?

@traversaro
Copy link
Member

I would avoid to name a branch v1.17.1, as that is the style that we use for tags.

@pattacini
Copy link
Member

I would avoid to name a branch v1.17.1, as that is the style that we use for tags.

The branch is just temporary as we're gonna churn out a tag v1.17.1 and soon afterward rebase master and devel on top.

@pattacini
Copy link
Member

pattacini commented Dec 10, 2020 •
edited
Loading

Uhm maybe there might be a conflict between the branch and the tag as their name is the same (and conceptually they are also pointers). Let me rename the branch then.

@traversaro
Copy link
Member

traversaro commented Dec 10, 2020 •
edited
Loading

I would avoid to name a branch v1.17.1, as that is the style that we use for tags.

The branch is just temporary as we're gonna churn out a tag v1.17.1 and soon afterward rebase master and devel on top.

Ack, to avoid confusion for the future we can use a different name for the temporary branch, something like b1.17.1 . Anyhow it is not really important.

@pattacini pattacini changed the base branch from v1.17.1 to fix/gravitycompensator December 10, 2020 15:48
@pattacini
Copy link
Member

Branch name changed into robotology:fix/gravitycompensator and PR updated.

@Nicogene Nicogene force-pushed the fix/gravityCompensator branch from 40ec096 to 81fc26e Compare December 10, 2020 16:36
pattacini
pattacini approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we don't really need to perform careful tests.

@pattacini pattacini merged commit d712e1c into robotology:fix/gravitycompensator Dec 10, 2020
@Nicogene Nicogene deleted the fix/gravityCompensator branch December 11, 2020 08:36
@Nicogene Nicogene mentioned this pull request Dec 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattacini pattacini pattacini approved these changes

Assignees

@Nicogene Nicogene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nicogene @traversaro @pattacini