Fix name clash with std::byte
#764
Conversation
| if(WIN32) | ||
| target_compile_definitions(skinManagerGui PUBLIC _HAS_STD_BYTE=0) | ||
| endif() |
There was a problem hiding this comment.
Apparently, there's a native problem with some Windows SDK and std::byte defined in C++17.
This problem impacts the compilation of some skinManagerGui auto-generated files.
Here's the proposed solution.
We also need to be careful as in the future _HAS_STD_BYTE will get removed.
There was a problem hiding this comment.
Can we open an issue on how to fix this in a more permanent way? Perhaps just avoiding a windows include or a using namespaces std somewhere in skinManagerGui could help in this case.
There was a problem hiding this comment.
[rem]: https://github.com/microsoft/STL/issues/20
I guess there was a typo and the correct issues is microsoft/STL#204 ?
There was a problem hiding this comment.
Can we open an issue on how to fix this in a more permanent way? Perhaps just avoiding a windows include or a
using namespaces stdsomewhere in skinManagerGui could help in this case.
Unfortunately, the failure is triggered within files that are generated by Qt, which in turn do include the "problematic" Windows SDK resources.
After a quick F2F alignment, we've decided to go this way.
Fixes #763.