Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored due to upgrade to YARP-3.5 to deal with changes to *Int, *Double, *Vocab and to use the latest yarp::conf utilities #773

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

pattacini
Copy link
Member

@pattacini pattacini commented Nov 21, 2021

@pattacini pattacini self-assigned this Nov 21, 2021
@pattacini pattacini force-pushed the feat/upgrade-yarp-3.5 branch 2 times, most recently from 0fbb23a to 07ca7fa Compare November 21, 2021 10:47
@pattacini pattacini changed the title Refactored due to upgrade to YARP-3.5 to deal with changes to *Int, *Double, *Vocab Refactored due to upgrade to YARP-3.5 to deal with changes to *Int, *Double, *Vocab and to use the latest yarp::conf utilities Nov 21, 2021
@pattacini pattacini force-pushed the feat/upgrade-yarp-3.5 branch from 07ca7fa to 1f0b34b Compare November 21, 2021 11:39
@pattacini
Copy link
Member Author

@traversaro @Nicogene @marcoaccame this is a quite huge PR that mainly aims to check the CI with a full compilation.

@pattacini pattacini force-pushed the feat/upgrade-yarp-3.5 branch 6 times, most recently from b4047cd to 1249463 Compare November 21, 2021 17:06
Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go through all the files, but LGTM

@pattacini
Copy link
Member Author

pattacini commented Nov 22, 2021

I'll merge the PR this afternoon.
@marcoaccame you could use the file-filtering features of the PR dashboard to display only embo* files.

@pattacini pattacini force-pushed the feat/upgrade-yarp-3.5 branch from 1249463 to 21e3bfc Compare November 22, 2021 12:03
@pattacini
Copy link
Member Author

pattacini commented Nov 22, 2021

Just specified that now YARP-3.5.1 is required.

Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just gave an overview, but everything seems fine.

@pattacini
Copy link
Member Author

Merging.
@marcoaccame you could check the content ex-post. In case, I'll fix any possible errors.

@pattacini pattacini merged commit 2e66ed0 into devel Nov 22, 2021
@pattacini pattacini deleted the feat/upgrade-yarp-3.5 branch November 22, 2021 13:06
Nicogene added a commit that referenced this pull request Nov 22, 2021
Increase the required version required in the deb packets, needed after #773
@Nicogene Nicogene mentioned this pull request Nov 22, 2021
pattacini pushed a commit that referenced this pull request Nov 22, 2021
Increase the required version required in the deb packets, needed after #773
@marcoaccame
Copy link
Contributor

Merging.
@marcoaccame you could check the content ex-post. In case, I'll fix any possible errors.

it seems ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants