Added support for amcbldc and pmc boards in FirmwareUpdater #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the program
FirmwareUpdaterto recognize the boardspmcandamcbldcfor its operativity.For this purpose, we need to define some enum values in
icub-firmware-shared(see the relevant PR) and to avoid compilation failure we also need to update the required version of icub-firmware-shared to be 1.22.1.A small but important change was to increase the timeout with which the
canloaderlibrary waits for a reply from theamcbldcandpmcafter it has sent them aBOOTLOADER:boardmessage. The reason is that these two new boards require longer time to perform their FLASH erase.For further details see also the following joint PR in icub-firmware, where we also document about the performed tests.
NOTE: The CI will fail because we need first to merge the PR on icub-firmware-shared.