Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ft service multiple sensors #786

Merged
merged 52 commits into from
Apr 4, 2022
Merged

Feat/ft service multiple sensors #786

merged 52 commits into from
Apr 4, 2022

Conversation

triccyx
Copy link
Member

@triccyx triccyx commented Mar 25, 2022

We are going to cover the following:

  • use up to 4 FT sensors for board through embObjMultipleFTsensors
  • add experimental Unit-test to icub-main device

@marcoaccame @pattacini

src/CMakeLists.txt Outdated Show resolved Hide resolved
@triccyx

This comment was marked as resolved.

@triccyx

This comment was marked as resolved.

@triccyx
Copy link
Member Author

triccyx commented Mar 31, 2022

As a first step, I deactivate tests on Windows as they have problems in the execution phase.

@pattacini
Copy link
Member

As a first step, I deactivate tests on Windows as they have problems in the execution phase.

From this CI, it seems that the install job fails too on Windows.

@traversaro
Copy link
Member

As a first step, I deactivate tests on Windows as they have problems in the execution phase.

I do not think it is strictly needed to fix this now, but as the error code is 0xc0000135, this means dll not found, so probably the root of the issue is the same of #784 .

@pattacini
Copy link
Member

I do not think it is strictly needed to fix this now, but as the error code is 0xc0000135, this means dll not found, so probably the root of the issue is the same of #784 .

Ok, then that's a good reason to focus first on Linux.

@triccyx
Copy link
Member Author

triccyx commented Apr 1, 2022

@marcoaccame
I have done:

  • Use of CAN board time offset
  • Check for the timeout interval between update

.clang-format Outdated Show resolved Hide resolved
@triccyx triccyx requested a review from pattacini April 4, 2022 12:37
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All points have been addressed 👍🏻
The remaining outstanding issues related to the Windows ecosystem will be tackled soon-ish.
Merging 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants