Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package versions in 2021.11.1 release #983

Merged
merged 6 commits into from
Jan 4, 2022

Conversation

traversaro
Copy link
Member

CI will probably fail as robotology/whole-body-estimators#135 still needs to be merged and released, but better to open this PR so we can check if we are missing some release.

@traversaro traversaro changed the title Update releases in 2021.11.1 release Update package versions in 2021.11.1 release Dec 31, 2021
@traversaro
Copy link
Member Author

Note that only the Default jobs need to be checked. @pattacini @Nicogene feel free to double check the updated versions.

@traversaro
Copy link
Member Author

CI is failing on ICUB with:

2022-01-03T08:54:30.9727656Z CMake Error at conf/iCubFindDependencies.cmake:76 (message):
2022-01-03T08:54:30.9728842Z   An old version of icub-firmware-shared has been detected, but at least
2022-01-03T08:54:30.9729537Z   1.22.2 is required
2022-01-03T08:54:30.9730004Z Call Stack (most recent call first):
2022-01-03T08:54:30.9730564Z   CMakeLists.txt:52 (include)

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me!
I had already checked the versions.

@traversaro
Copy link
Member Author

This seems to ndicate

CI is failing on ICUB with:

2022-01-03T08:54:30.9727656Z CMake Error at conf/iCubFindDependencies.cmake:76 (message):
2022-01-03T08:54:30.9728842Z   An old version of icub-firmware-shared has been detected, but at least
2022-01-03T08:54:30.9729537Z   1.22.2 is required
2022-01-03T08:54:30.9730004Z Call Stack (most recent call first):
2022-01-03T08:54:30.9730564Z   CMakeLists.txt:52 (include)

This seems to indicate the icub v1.23.1 requires icub-firmware-shared v1.22.2, but there is no such release. @pattacini @mfussi66 @Nicogene

@pattacini
Copy link
Member

pattacini commented Jan 3, 2022

This seems to ndicate

CI is failing on ICUB with:

2022-01-03T08:54:30.9727656Z CMake Error at conf/iCubFindDependencies.cmake:76 (message):
2022-01-03T08:54:30.9728842Z   An old version of icub-firmware-shared has been detected, but at least
2022-01-03T08:54:30.9729537Z   1.22.2 is required
2022-01-03T08:54:30.9730004Z Call Stack (most recent call first):
2022-01-03T08:54:30.9730564Z   CMakeLists.txt:52 (include)

This seems to indicate the icub v1.23.1 requires icub-firmware-shared v1.22.2, but there is no such >release. @pattacini @mfussi66 @Nicogene

The following 2 PR have increased the patch numbers:

We need to generate a new release of icub-firmware-shared.
cc @Nicogene @marcoaccame

@traversaro
Copy link
Member Author

We need to generate a new release of icub-firmware-shared.

A merge of devel in master is also necessary, otherwise #984 will fail.

@pattacini
Copy link
Member

We need to generate a new release of icub-firmware-shared.
cc @Nicogene @marcoaccame

Therefore, we need to double-check what to do w/ icub-firmware-* repos too.

@traversaro
Copy link
Member Author

traversaro commented Jan 3, 2022

CI will probably fail as robotology/whole-body-estimators#135 still needs to be merged and released, but better to open this PR so we can check if we are missing some release.

I just released whole-body-estimator v0.6.1, so CI now should work fine w.r.t. to that.

@Nicogene
Copy link
Member

Nicogene commented Jan 3, 2022

I updated manually the icub-firmware-shared and icub-firmware versions directly on the release branch by mistake sorry 😞

61a9051

We need to rebase this branch, and I am awaiting the @marcoaccame greenlight for tagging icub-firmware-build

@traversaro
Copy link
Member Author

We need to rebase this branch

Done!

@traversaro
Copy link
Member Author

CI still fails with:

2022-01-03T14:40:37.5662124Z FAILED: modules/iCubBlinker/CMakeFiles/iCubBlinker.dir/iCubBlinker_IDL.cpp.o 
2022-01-03T14:40:37.5666313Z /usr/bin/c++  -I/home/runner/work/robotology-superbuild/robotology-superbuild/build/src/funny-things/modules/iCubBlinker -isystem /home/runner/work/robotology-superbuild/robotology-superbuild/build/install/include -O3 -DNDEBUG -std=c++17 -MD -MT modules/iCubBlinker/CMakeFiles/iCubBlinker.dir/iCubBlinker_IDL.cpp.o -MF modules/iCubBlinker/CMakeFiles/iCubBlinker.dir/iCubBlinker_IDL.cpp.o.d -o modules/iCubBlinker/CMakeFiles/iCubBlinker.dir/iCubBlinker_IDL.cpp.o -c /home/runner/work/robotology-superbuild/robotology-superbuild/build/src/funny-things/modules/iCubBlinker/iCubBlinker_IDL.cpp
2022-01-03T14:40:37.5671172Z /home/runner/work/robotology-superbuild/robotology-superbuild/build/src/funny-things/modules/iCubBlinker/iCubBlinker_IDL.cpp:17:11: error: "'blink_fast' will never be called, since 'blink' starts with the same tag"
2022-01-03T14:40:37.5673048Z    17 | YARP_COMPILER_ERROR("'blink_fast' will never be called, since 'blink' starts with the same tag")
2022-01-03T14:40:37.5673818Z       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2022-01-03T14:40:37.5675457Z /home/runner/work/robotology-superbuild/robotology-superbuild/build/src/funny-things/modules/iCubBlinker/iCubBlinker_IDL.cpp:18:11: error: "'blink_naturalistic' will never be called, since 'blink' starts with the same tag"
2022-01-03T14:40:37.5677237Z    18 | YARP_COMPILER_ERROR("'blink_naturalistic' will never be called, since 'blink' starts with the same tag")
2022-01-03T14:40:37.5678046Z       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2022-01-03T14:40:37.5678856Z [6/10] Building CXX object modules/iCubBlinker/CMakeFiles/iCubBlinker.dir/main.cpp.o
2022-01-03T14:40:37.5679960Z [7/10] Building CXX object modules/funnyPostures/CMakeFiles/funnyPostures.dir/main.cpp.o
2022-01-03T14:40:37.5680842Z ninja: build stopped: subcommand failed.

So we need to bump funny-things.

@pattacini
Copy link
Member

So we need to bump funny-things.

cc @Nicogene

@traversaro
Copy link
Member Author

So we need to bump funny-things.

cc @Nicogene

I did this in 7da8642 .

@traversaro
Copy link
Member Author

The only failures are in specific systems that did not had fixes from the master branch to build, but the versions of the 2021.11.1 release are working fine.

@traversaro traversaro merged commit 18fd878 into releases/2021.11 Jan 4, 2022
@traversaro traversaro deleted the traversaro-patch-4 branch January 4, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants