Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port all the robots' configuration to the TemperatureSensorType parameter #606

Closed
Nicogene opened this issue Jan 8, 2024 · 2 comments
Closed
Assignees
Labels

Comments

@Nicogene
Copy link
Member

Nicogene commented Jan 8, 2024

@AntonioConsilvio pointed me out that this PR:

removes the old parameter HasTempSensor replacing it with TemperatureSensorType, this means that on icub-main@devel several robots cannot start right now, see:

cc @valegagge @MSECode

@MSECode
Copy link
Contributor

MSECode commented Jan 8, 2024

Since the code is retro-compatible, it should start even if using the old parameter HasTempSensor if this one is set to zero. As shown by the tests done here:
https://github.com/icub-tech-iit/study-motor-temperature/issues/13
So if we do not have the type of sensor on the motor or do we not need it, we can leave the configurations as they are
But i'll check it

@valegagge
Copy link
Member

valegagge commented Jan 8, 2024

Since the code is retro-compatible, it should start even if using the old parameter HasTempSensor if this one is set to zero. As shown by the tests done here: icub-tech-iit/study-motor-temperature#13 (comment) So if we do not have the type of sensor on the motor or do we not need it, we can leave the configurations as they are But i'll check it

it is correct! we don't need to update the configuration of all robots unless the user wants to read the temperature sensor in case the robot has it.

So I think we can close this issue

@Nicogene Nicogene closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants