You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
removes the old parameter HasTempSensor replacing it with TemperatureSensorType, this means that on icub-main@devel several robots cannot start right now, see:
Since the code is retro-compatible, it should start even if using the old parameter HasTempSensor if this one is set to zero. As shown by the tests done here: https://github.com/icub-tech-iit/study-motor-temperature/issues/13
So if we do not have the type of sensor on the motor or do we not need it, we can leave the configurations as they are
But i'll check it
Since the code is retro-compatible, it should start even if using the old parameter HasTempSensor if this one is set to zero. As shown by the tests done here: icub-tech-iit/study-motor-temperature#13 (comment) So if we do not have the type of sensor on the motor or do we not need it, we can leave the configurations as they are But i'll check it
it is correct! we don't need to update the configuration of all robots unless the user wants to read the temperature sensor in case the robot has it.
@AntonioConsilvio pointed me out that this PR:
removes the old parameter
HasTempSensor
replacing it withTemperatureSensorType
, this means that on icub-main@devel several robots cannot start right now, see:cc @valegagge @MSECode
The text was updated successfully, but these errors were encountered: