Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WARNING]: WBC library of matlab functions will be transformed into a package in the future release #52

Closed
gabrielenava opened this issue Dec 14, 2018 · 3 comments
Assignees
Labels

Comments

@gabrielenava
Copy link
Collaborator

gabrielenava commented Dec 14, 2018

In the current master branch, there is a library of matlab utility functions that are used by the controllers. However, we have other controllers in other github organizations, including matlab-simulators that use local copies of these functions. I decided to convert this library in a package in order to:

  • avoid to duplicate the library in several repositories;
  • allow to permanently add the library to the Matlab path. If I don't use the package, it may be difficult to understand which function is used in case there are functions with the same name in other folders in the path (there may be random failures, e.g. imagine you have your local version of the skew function in your local path. If for some reason the path to your local version of skew is not loaded, and the library of whole-body-controllers is in the Matlab path, your code may run anyways, but unexpected results may occur.

The modification has been implemented and tested in this PR. When it will be merged into master, all the standard demos (yoga, standup, impedance) should work as before. All other not officially supported demos can work as before as well, provided that the user adds the prefix wbc. to the name of all the functions of the library when there is a call to these functions. E.g.:


function [ ] = myRandomFunction ()

   % call to one of the functions in the library (add wbc.)
   [outputs] = wbc.nameOfFunctionInsideTheLibrary(inputs)
end

cc @Yeshasvitvs @aikolina

@gabrielenava gabrielenava added this to the next-software-upgrade milestone Dec 14, 2018
@gabrielenava gabrielenava self-assigned this Dec 14, 2018
@gabrielenava gabrielenava modified the milestones: next-software-upgrade, current-software-update Dec 15, 2018
@gabrielenava
Copy link
Collaborator Author

Closing. I sent an email.

@yeshasvitirupachuri
Copy link
Member

@gabrielenava The PR link is broken.

@gabrielenava
Copy link
Collaborator Author

link restored, thanks!

@gabrielenava gabrielenava removed this from the current-software-update milestone Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants