Deprecate *Vocab methods in favour of *Vocab32 #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdanz
added
PR Type: Feat/Enh
drdanz
requested review from
Nicogene,
pattacini,
randaz81 and
traversaro
as code owners
pattacini
approved these changes
Jul 9, 2021
drdanz
force-pushed
the
vocab32_part2
branch
2 times, most recently
from
b8d7918 to
b84809e
Compare
|
SonarCloud Quality Gate failed. |
drdanz
added
the
PR Status: Continuous Integration - OK
* `yarp::os::createVocab()` is deprecated in favour of `yarp::os::createVocab32()` * `yarp::os::Vocab::encode()` is deprecated in favour of `yarp::os::Vocab32::encode()` * `yarp::os::Vocab::decode()` is deprecated in favour of `yarp::os::Vocab32::decode()` * `yarp::os::Value::isVocab()` is deprecated in favour of `yarp::os::Value::isVocab32()` * `yarp::os::Value::asVocab()` is deprecated in favour of `yarp::os::Value::asVocab32()` * `yarp::os::Value::makeVocab()` is deprecated in favour of `yarp::os::Value::makeVocab32()` * `yarp::os::Bottle::addVocab()` is deprecated in favour of `yarp::os::Bottle::addVocab32()` * `yarp::os::WireReader::getIsVocab()` is deprecated in favour of `yarp::os::WireReader::getIsVocab32()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2629, part of the methods where already replaced, but while updating another repo I realized that not all of them were ready. This has the unexpected advantage to make it easier to update (`/s/Vocab/Vocab32/g' will work in most cases).
This patch also adds a few overloads to avoid writing several time
Vocab32when it does not add any information.For example:
-reply.addVocab(yarp::os::Vocab::encode("many"));becomes
+reply.addVocab32("many");Libraries
osyarp::os::createVocab()is deprecated in favour ofyarp::os::createVocab32()yarp::os::Vocab::encode()is deprecated in favour ofyarp::os::Vocab32::encode()yarp::os::Vocab::decode()is deprecated in favour ofyarp::os::Vocab32::decode()yarp::os::Value::isVocab()is deprecated in favour ofyarp::os::Value::isVocab32()yarp::os::Value::asVocab()is deprecated in favour ofyarp::os::Value::asVocab32()yarp::os::Value::makeVocab()is deprecated in favour ofyarp::os::Value::makeVocab32()yarp::os::Bottle::addVocab()is deprecated in favour ofyarp::os::Bottle::addVocab32()yarp::os::WireReader::getIsVocab()is deprecated in favour ofyarp::os::WireReader::getIsVocab32()BottleaddVocab32()overloads accepting 4 chars and stringValuemakeVocab32()overload accepting 4 charsidl/WireWriteraddVocab32()overloads accepting 4 chars and string