Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake version dependent inconsistency #314

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Fix CMake version dependent inconsistency #314

merged 1 commit into from
Feb 7, 2020
+4 −1

Conversation

mbeutel
Copy link
Contributor

@mbeutel mbeutel commented Jan 29, 2020

Unfortunately the code in my previous PR #269 ended up behaving inconsistently depending on the CMake version. Cf. #262 (comment) for an explanation.

traversaro
traversaro approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@weekly-digest weekly-digest bot mentioned this pull request Feb 1, 2020
Closed
@traversaro traversaro mentioned this pull request Feb 6, 2020
Closed
@drdanz drdanz merged commit bb93539 into robotology:master Feb 7, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 8, 2020
Closed
@PeterBowman
Copy link
Member

@drdanz shouldn't this patch be backported into the ycm-0.11 branch, same as #269?

@drdanz
Copy link
Member

drdanz commented Mar 26, 2020

@PeterBowman I think #269 is a change of behaviour therefore I wouldn't backport it. @traversaro what do you think?

@PeterBowman
Copy link
Member

My point: #269 already is a v0.11.x feature, and I perceive this patch (#314) as a related bugfix.

@drdanz
Copy link
Member

drdanz commented Mar 26, 2020

Right, sorry, I didn't realize that! Thanks for pointing that out.
Cherrypicked in the ycm-0.11 branch (see e1d7b80)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

@drdanz drdanz drdanz approved these changes

Assignees
No one assigned
Labels
Component: Modules Module: InstallBasicPackageFiles Resolution: Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbeutel @PeterBowman @drdanz @traversaro