Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.0 broke something on macOS 10.10 #187

Open
justvanrossum opened this issue May 23, 2023 · 11 comments
Open

0.3.0 broke something on macOS 10.10 #187

justvanrossum opened this issue May 23, 2023 · 11 comments

Comments

@justvanrossum
Copy link
Collaborator

justvanrossum commented May 23, 2023

In FontGoggles, clicking on the "Variations" tab makes the whole tab move to the bottom of the parent, rendering it unusable.

0.3.0:
image

0.2.4:
image

This does not seem to happen on macOS 10.15.

It may not be worth fixing this, but I thought I could at least document it.

@typemytype
Copy link
Member

macOS 10.10 is released in 2014....

I guess a more clear statement of vanilla support over different macOS version could help here...

We should consider that we cannot keep up supporting the latest macOS with losing older macOS versions.

@justvanrossum
Copy link
Collaborator Author

What would be the next reasonable lowest version? 10.15? 10.14?

@typemytype
Copy link
Member

no idea...

things to consider:

  • py3.9 EOL is October 2025
  • switch between intel M1
  • M1 is only Monterey+

@typemytype
Copy link
Member

does it happens for each tab view? or only a tab view inside a splitview?

maybe a small example?

the change in vanilla was a move for the tab view to a NSTabViewController

@justvanrossum
Copy link
Collaborator Author

Hard to say, I but I'll try to make a small reproducer.

@khaledhosny
Copy link

I got a report of a similar issue affecting macOS 11.7 Nagwa-Limited-Community/Glyphs-MATH-Plugin#5

@chrisjansky
Copy link

Related: SegmentedButton doesn’t respect posSize for me on Mac OS 12.3.1

Screenshot:
image

Test case:

import vanilla

def run():
    w = vanilla.Window(
        (400, 400),
    )
    w.btn = vanilla.SegmentedButton(
        (10, 10, -10, 20),
        [
            dict(title="Very Long Title"),
            dict(title="Another Long Title"),
            dict(title="Long Title Indeed"),
        ],
    )

    w.open()
    w.center()

run()

Same code executed with executeVanillaTest works fine:
image

@typemytype
Copy link
Member

could you test with the latest vanilla from the repo?
the vanilla version on pypi is behind

@chrisjansky
Copy link

@typemytype Not sure I follow, I am using vanilla v0.3.0 which looks like the latest version here on GitHub Releases also

@typemytype
Copy link
Member

true, but the latest commit is newer and already fixed this issue, sorry for being lazy on the releases

pip3 install git+https://github.com/robotools/vanilla to install the latest from this repo

@justvanrossum
Copy link
Collaborator Author

This issue still persist, even in the latest version in git.

@justvanrossum justvanrossum reopened this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants