Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option -p should print sidecar containers resource usage #157

Open
YvesZelros opened this issue Jul 8, 2024 · 1 comment
Open

Option -p should print sidecar containers resource usage #157

YvesZelros opened this issue Jul 8, 2024 · 1 comment

Comments

@YvesZelros
Copy link

YvesZelros commented Jul 8, 2024

Kubernetes v1.29 have introduce sidecar containers

https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/

Sidecar containers are used as exemple by istio

kube-capacity -p should print sidecar containers resource usage

Note:
sidecar containers are visible with kubectl top pods --containers=true

@ahmetb
Copy link

ahmetb commented Aug 7, 2024

I also agree that this project should take initContainers as well as sidecar containers into account. There's non trivial calculation that goes into calculating what stage the container in, how much does that initContainer –or containers[]+sidecars[] request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants