-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorrect data #66
Comments
Hey @christiancadieux, thanks for reporting this! I'm not sure how soon I'll be able to fix this, but very open to PRs. |
The same. I wil try to fix this |
Thanks @cloud-66! |
Seems to happen when the deployment requests / limits has been specified using
Then
|
@christiancadieux @edrandall You should try, this issue was fixed by #71 |
in some cases, memory values for a node will not include the 'Mi' suffix:
In these cases, the report is wrong. need to change the logic here:
https://github.com/robscott/kube-capacity/blob/master/pkg/capacity/resources.go#L356
for example, use more specific requestString and limitString so the code does not fall on the wrong unit:
Example: add requestStringM() and limitStringM() that only converts Memory units to avoid the problem::
The text was updated successfully, but these errors were encountered: