Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add samples for Map.size to api-fluent and api-infix #1039

Closed
4 tasks
robstoll opened this issue Oct 29, 2021 · 2 comments · Fixed by #1041
Closed
4 tasks

add samples for Map.size to api-fluent and api-infix #1039

robstoll opened this issue Oct 29, 2021 · 2 comments · Fixed by #1041
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

See other samples in MapFeatureExtractorSamples (e.g. valuesFeature and values) we want the same for the function size

  • add sizeFeature and size to MapFeatureExtractorSamples in api-fluent
  • add @sample to the corresponding functions in mapFeatureExtractors.kt in api-fluent
  • add sizeFeature and size to MapFeatureExtractorSamples in api-infix
  • add @sample to the corresponding functions in mapFeatureExtractors.kt in api-infix

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@ashwini-desai
Copy link
Contributor

@robstoll : I'll work on this

@ashwini-desai
Copy link
Contributor

@robstoll : Raised a PR

@robstoll robstoll added this to the 0.18.0 milestone Oct 31, 2021
@robstoll robstoll linked a pull request Nov 1, 2021 that will close this issue
@robstoll robstoll closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants