Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add samples for ListFeatureExtractorSamples to api-fluent and api-infix #1045

Closed
8 tasks
robstoll opened this issue Nov 4, 2021 · 6 comments
Closed
8 tasks
Assignees
Labels

Comments

@robstoll
Copy link
Owner

robstoll commented Nov 4, 2021

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

See ListFeatureExtractorSamples in api-fluent and ListFeatureExtractorSamples in api-infix, we want similar samples for iterableSubjectChangers.kt

  • create ListFeatureExtractorSamples in api-fluent
  • add function getFeature for the first function/overload of get in listFeatureExtractors.kt (see CollectionFeatureExtractorSamples..sizeFeature as a guideline)
  • add function get for the second overload of get in listFeatureExtractors.kt (see CollectionFeatureExtractorSamples as a guideline)
  • add @sample tag to the functions in listFeatureExtractors.kt
  • create ListFeatureExtractorSamples in api-infix
  • add function getFeature for the first function/overload of get in listFeatureExtractors.kt (see CollectionFeatureExtractorSamples..sizeFeature as a guideline)
  • add function get for the second overload of get in listFeatureExtractors.kt (see CollectionFeatureExtractorSamples as a guideline)
  • add @sample tag to the functions in listFeatureExtractors.kt

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@robstoll robstoll changed the title add samples for iterableSubjectChangers to api-fluent and api-infix add samples for ListFeatureExtractorSamples to api-fluent and api-infix Jun 14, 2022
@simonNozaki
Copy link
Contributor

simonNozaki commented Jun 14, 2022

At #1129 , thanks to introducing query that can search easier issues, I'll work on this.

First of all, I could some samples of ListFeatureExtractorSamples, ListFeatureExtractorSamples. And, it seems that ListFeatureExtractor provides functions like mappings of expectations. I can understand what to do on this issue.

So would you tell me what functions package ch.tutteli.atrium.api.fluent.en_GB may hold, please?

@robstoll
Copy link
Owner Author

@simonNozaki see todos in issue description. They describe step by step what you need to do. Does that help?

@simonNozaki
Copy link
Contributor

@simonNozaki see todos in issue description. They describe step by step what you need to do. Does that help?

Sorry so much, I missed the description of issue. I can maybe do this by todos with step by step .

@simonNozaki
Copy link
Contributor

simonNozaki commented Jun 15, 2022

Hi, @robstoll .

Again seeing projects, it seems that ListFeatureExtractorSamples already exists in ch.tutteli.atrium.api.infix.en_GB.samples and ch.tutteli.atrium.api.fluent.en_GB.samples.

And these class has both getFeature and both, so I think this issue can be closed because of sample codes.

Or...What to do is adding samples like ListFeatureExtractorSamples to iterableSubjectChangers sample class?

@robstoll
Copy link
Owner Author

robstoll commented Jun 15, 2022

You're right, sorry about that. Looks like I already added it and forgot to close the issue. Take a look at #1038 this one is still open. Please leave a comment there as well, so that I can assign the issue to you

@simonNozaki
Copy link
Contributor

@robstoll

Oh, great, I see!. So, please assign me to #1038. I'm ready to add samples for iterableSubjectChangers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants