Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add samples for BigDecimal expectation functions in api-infix #1505

Closed
robstoll opened this issue Aug 11, 2023 · 3 comments · Fixed by #1513
Closed

add samples for BigDecimal expectation functions in api-infix #1505

robstoll opened this issue Aug 11, 2023 · 3 comments · Fixed by #1513
Assignees
Labels
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Aug 11, 2023

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

We already have samples in ch.tutteli.atrium.api.fluent.en_GB.samples.BigDecimalExpectationSamples but only cover expect toEqual ... in api-infix. We want to cover the rest of the functions as well.

TODO:

  • make sure every function in apis/infix/atrium-api-infix/src/jvmMain/kotlin/ch/tutteli/atrium/api/infix/en_GB/bigDecimalExpectations.kt which is not deprecated has a corresponding sample in ch.tutteli.atrium.api.infix.en_GB.samples.BigDecimalExpectationSamples and links to it => see toEqual in bigDecimalExpectations.kt for an already implemented case (and take a look at ch.tutteli.atrium.api.fluent.en_GB.samples.BigDecimalExpectationSamples as guidance for the samples, make sure you use the infix api though.)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@VarunEnishetty
Copy link
Contributor

Hi @robstoll , I would like to work on this issue.
Can you please assign this task to me and also help me with any changes to considered?

@robstoll
Copy link
Owner Author

@VarunEnishetty the description should still fit, let me know if you have questions

@VarunEnishetty
Copy link
Contributor

@robstoll , can you please look into this PR - #1513

@robstoll robstoll added this to the 1.1.0 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants