Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure dependabot to update samples #349

Closed
1 task
robstoll opened this issue Feb 4, 2020 · 4 comments · Fixed by #604
Closed
1 task

configure dependabot to update samples #349

robstoll opened this issue Feb 4, 2020 · 4 comments · Fixed by #604
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Feb 4, 2020

Platform (jvm, js, android):
Extension (none, kotlin 1.3, jdk8): none

Non-Code related feature

Is your feature request related to a problem? Please describe.
Yes, the dependencies of the samples projects get out of date if we don't update them.

Describe the solution you'd like
We already use dependabot and it supports monorepos, thus we can configure it accordingly.

Describe alternatives you've considered
We used non-dependent projects first (still the case for mocha and jasmine samples at the time of writing)

TODO

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@robstoll robstoll added help wanted good first issue Good for newcomers and removed good first issue Good for newcomers help wanted labels Feb 4, 2020
@robstoll
Copy link
Owner Author

robstoll commented Feb 4, 2020

blocked until we decide what to do with robstoll/atrium-roadmap#69

@robstoll
Copy link
Owner Author

since renovate does not support sub-projects (yet), we should setup/configure dependabot instead (samples are outdated now, so if the configuration is done correctly, then dependabot should propose to upgrade them to Atrium v0.13.0)

@robstoll robstoll added the good first issue Good for newcomers label Oct 1, 2020
@uzilan
Copy link
Contributor

uzilan commented Oct 10, 2020

I'd like to try to help with this one

@uzilan
Copy link
Contributor

uzilan commented Oct 10, 2020

Tried setting it up in my fork and as you said @robstoll - it created PRs for updating Atrium to v0.13.0, as can be seen here: https://github.com/uzilan/atrium/pulls

@robstoll robstoll added this to the 0.14.0 milestone Oct 18, 2020
@robstoll robstoll linked a pull request Oct 18, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants