Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add samples for mapExpectations of api-infix #861

Closed
2 tasks
robstoll opened this issue Apr 7, 2021 · 2 comments · Fixed by #912
Closed
2 tasks

add samples for mapExpectations of api-infix #861

robstoll opened this issue Apr 7, 2021 · 2 comments · Fixed by #912
Assignees
Labels
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Apr 7, 2021

Platform (all, jvm, js, android): all
Extension (none, kotlin 1.3): none

Code related feature

We also want to provide samples for the infix api

Following the things you need to do:

  • copy MapExpectationSample from fluent-api, adjust imports ...api.fluent... to ...api.infix... and ajdust the samples accordingly (always use the infix syntax, never the fluent).
  • check that the sample in the KDoc Intellij shows looks good (ALT+Mouse-click on function name)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@kacmacuna
Copy link
Contributor

I'll work on this

@robstoll robstoll changed the title add samples for mapAssertions of api-infix add samples for mapExpectations of api-infix May 22, 2021
@robstoll robstoll added this to the 0.17.0 milestone May 22, 2021
@robstoll
Copy link
Owner Author

@kacmacuna sorry, looks like you did not realise that the description was outdated as well. I have updated it but forgot to let you know

@robstoll robstoll linked a pull request Jun 3, 2021 that will close this issue
2 tasks
@robstoll robstoll closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants