Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add samples for bigDecimalExpectations of api-fluent #904

Closed
2 tasks
robstoll opened this issue May 20, 2021 · 2 comments · Fixed by #988
Closed
2 tasks

add samples for bigDecimalExpectations of api-fluent #904

robstoll opened this issue May 20, 2021 · 2 comments · Fixed by #988
Assignees
Labels
Milestone

Comments

@robstoll
Copy link
Owner

Code related feature

See for the initial request: #624

With this issue we want to add samples for bigDecimalExpectations.kt of api-fluent

Following the things you need to do:

api-fluent

  • add one function per non-deprecated function in bigDecimalExpectations.kt to BigDecimalExpectationSamples (see BigDecimalExpectationSamples)
  • refer to the sample in the KDoc of the corresponding function in bigDecimalExpectations via @sample (check out toEqual in anyExpectations.kt to see how you have to refer to the sample)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@timacosta
Copy link
Contributor

I'll work on this. I've been just checking similar issues and PRs related to it so feel free to assign it to me if there is no issue.

@timacosta
Copy link
Contributor

@robstoll PR #988 for this. Feel free to comment in the PR if it needs to be extended or if any explanatory comment is necessary.

@robstoll robstoll added this to the 0.17.0 milestone Sep 24, 2021
@robstoll robstoll linked a pull request Sep 24, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants