Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add samples for pathExpectations of api-fluent #919

Closed
3 tasks
robstoll opened this issue May 22, 2021 · 1 comment · Fixed by #930
Closed
3 tasks

add samples for pathExpectations of api-fluent #919

robstoll opened this issue May 22, 2021 · 1 comment · Fixed by #930
Assignees
Labels
Milestone

Comments

@robstoll
Copy link
Owner

Code related feature

With this issue we want to add samples for pathExpectations.kt of api-fluent

Following the things you need to do:

api-fluent

  • add one function per function in pathExpectations.kt and non deprectated function in pathAssertions to PathExpectationSamples (see PathExpectationSamples)
  • for functions having two overloads where one expects an assertionCreator in addition -- add the suffix Feature to the function name of the one not expecting assertionCreator (see ListExpectationSamples)
  • refer to the sample in the KDoc of the corresponding function in pathExpectations and pathAssertions via @sample (check out toEqual in anyExpectations.kt to see how you have to refer to the sample)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@kacmacuna
Copy link
Contributor

I'll work on this

@robstoll robstoll linked a pull request Jun 7, 2021 that will close this issue
3 tasks
@robstoll robstoll added this to the 0.17.0 milestone Jun 7, 2021
@robstoll robstoll closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants