Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add samples for iterableExpectations of api-infix #992

Closed
2 tasks
robstoll opened this issue Oct 6, 2021 · 1 comment · Fixed by #1012
Closed
2 tasks

add samples for iterableExpectations of api-infix #992

robstoll opened this issue Oct 6, 2021 · 1 comment · Fixed by #1012
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Oct 6, 2021

Platform (all, jvm, js, android): all
Extension (none, kotlin 1.3): none

Code related feature

We also want to provide samples for the infix api

Following the things you need to do:

  • copy IterableExpectationSamples from fluent-api, adjust imports ...api.fluent... to ...api.infix... and adjust the samples accordingly (always use the infix syntax, never the fluent).
  • check that the sample in the KDoc Intellij is showing looks good (ALT+Mouse-click on function name) -- see ListExpectationSamples for how comments are written for the infix API

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@vinayak03
Copy link
Contributor

I will work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants