Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian package fixes #7

Closed
6 tasks done
gavv opened this issue Nov 27, 2022 · 14 comments
Closed
6 tasks done

Debian package fixes #7

gavv opened this issue Nov 27, 2022 · 14 comments

Comments

@gavv
Copy link
Member

gavv commented Nov 27, 2022

Minor issues with debian packages implemented in #5.

@viccie30
Copy link
Contributor

I can give this a go if you'd like?

@gavv
Copy link
Member Author

gavv commented Nov 27, 2022

Awesome, thanks!

@viccie30
Copy link
Contributor

Looking at Debian bug #1002724, it seems that @dankamongmen might also be interested in this.

@dankamongmen
Copy link
Contributor

yeah, i had been planning on packaging this up (see #4 (comment)), but if you already got to it, godspeed

@viccie30
Copy link
Contributor

I don't use openfec and/or roc-toolkit myself (anymore), but I had packaged both some time ago. If you actually use both, I'd be happy to give the packaging code to you or co-maintain it with you, whichever you prefer.

@dankamongmen
Copy link
Contributor

I don't use openfec and/or roc-toolkit myself (anymore), but I had packaged both some time ago. If you actually use both, I'd be happy to give the packaging code to you or co-maintain it with you, whichever you prefer.

are you a DD? if so, i'm happy to comaintain, or maintain myself, or leave it to you. if not, and you'd like to become one, i'd be happy to sponsor your upload. i didn't mean to assert any claim to territory, just to let you know i've done some work here too =]. i've got packaging for it somewhere around here, but i doubt there's much difference between ours. have you pushed to salsa?

dankamongmen@gmail.com if you'd like to take this to email (either way is fine for me).

@viccie30
Copy link
Contributor

I have a draft version for inclusion in Debian at https://salsa.debian.org/viccie30/openfec. Getting it uploaded to Debian depends at the very least on the resolution of #9.

@gavv
Copy link
Member Author

gavv commented Nov 28, 2022

I've edited the first sub-task in the issue:

[...] and tags from 1.2.3 to v1.2.3

@gavv gavv added the packaging label Nov 29, 2022
@twojstaryzdomu
Copy link

I'll try to answer those one by one:

On the item

Rename releases from openfec_1.2.3 to v1.2.3 and tags from 1.2.3 to v1.2.3

@gavv, have you tried editing the variable tag_name and setting release_name with to v${VERSION} and ${PACKAGE}_v${VERSION}?

@gavv
Copy link
Member Author

gavv commented Nov 29, 2022

@gavv, have you tried editing the variable tag_name and setting release_name with to v${VERSION} and ${PACKAGE}_v${VERSION}?

Nope, I didn't try it. I guess it's what we need.

@twojstaryzdomu
Copy link

twojstaryzdomu commented Nov 29, 2022

Please let me know if it worked. As for the other items, these need to be checked if they do not break a subsequent roc-toolkit build (especially the inclusion of C files), some choices may have be intentional. I will reply shortly.

@gavv
Copy link
Member Author

gavv commented Dec 1, 2022

@twojstaryzdomu Thanks, your suggestion helped!

@viccie30 I've marked Rename releases from openfec_1.2.3 to v1.2.3 and tags from 1.2.3 to v1.2.3 as complete. See b452e08

@twojstaryzdomu Regarding C files: I believe roc doesn't need them, it needs only headers.

@gavv
Copy link
Member Author

gavv commented Mar 5, 2023

Hi, I've fixed the remaining issues and tagged v1.4.2.7

@gavv gavv closed this as completed Mar 5, 2023
@gavv
Copy link
Member Author

gavv commented Mar 10, 2023

@dankamongmen @viccie30 FYI: both openfec and roc-toolkit now build debian packages on release and attach them to release assets.

In case you would like to reuse debian/ directory from the repo, and need some adjustments, feel free to ping me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants