Services integration 3 #123
Conversation
| required Future<void> Function() inactiveFunction, | ||
| required Future<void> Function() activeFunction, |
There was a problem hiding this comment.
Nit: maybe name like activatedFunction / deactivatedFunction would be more intuitive (it'd suggest that they are called on event).
| @override | ||
| final Event<Value<String>> stateChangeEvent = Event("stateChangeEvent"); |
There was a problem hiding this comment.
It's preferably to use enums instead of string identifiers. If you change a string in one place, but forget to change it in another, you won't get a compiler error and the change will remain unnoticed.
We could introduce BackendEvent enum and use Event<Value<BackendEvent>>. Alternatively, we can create two separate events without values at all: senderStateChangeEvent and receiverStateChangeEvent.
| @override | ||
| bool receiverIsAlive = false; | ||
|
|
||
| @override | ||
| bool senderIsAlive = false; |
There was a problem hiding this comment.
Since receiverIsAlive/senderIsAlive values are now cached until onAnyEvents is called, it can lead to a small inconsistency: model calls startReceiver() and then reads receiverIsAlive and it can see that it's false just because event was not delivered from kotlin to dart yet.
To avoid this, we can update startReceiver/stopReceiver/startSender/stopSender so that they will update receiverIsAlive/senderIsAlive before returning.
| ModelRoot(Logger logger, Backend backend) { | ||
| this.receiver = Receiver(logger, backend); | ||
| this.receiver.setDefultValues(); |
There was a problem hiding this comment.
Maybe inline setDefultValues logic into ctor? Isn't it an implementation detail?
There was a problem hiding this comment.
It seems that we can remove setReceiverIPs() method. UI doesn't need to set write this field, only read it.
No description provided.