Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve debug logs #53

Closed
ortex opened this issue Jan 28, 2023 · 0 comments · Fixed by #97
Closed

Improve debug logs #53

ortex opened this issue Jan 28, 2023 · 0 comments · Fixed by #97
Assignees
@ortex
Labels
enhancement New feature or request

Comments

@ortex
Copy link
Member

ortex commented Jan 28, 2023 •
edited by gavv
Loading

Add debug logs on java side for all non-realtime operations:

  • opening and closing context/sender/receiver
  • bind and connect
  • registering/unregistering/collecting object in NativeObjectCleaner
  • loading jni library first time (RocLibrary)

These operations should log their arguments.

If operation does a call to a native method, it should write to log before and after native call. This is useful when debugging crashes in native code.

Background: roc-streaming/roc-droid#45 (comment)
@ortex ortex mentioned this issue Jan 28, 2023
Open
@gavv gavv changed the title Add logs Improve debug logs Feb 5, 2023
@gavv gavv added enhancement New feature or request good first issue Good for newcomers help wanted Contributions are welcome labels Feb 5, 2023
@ortex ortex mentioned this issue May 11, 2023
Merged
@gavv gavv removed good first issue Good for newcomers help wanted Contributions are welcome labels May 12, 2023
@ortex ortex closed this as completed in #97 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ortex ortex

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add debug logs; remove custom handler api roc-streaming/roc-java
2 participants
@ortex @gavv