Merge pull request #399 from roclark/fix-nfl-invalid-player-weight

Handle missing player weights throwing errors

sportsreference/mlb/roster.py

@@ -746,6 +746,8 @@ def weight(self):
         """
         Returns an ``int`` of the player's weight in pounds.
         """
+        if not self._weight:
+            return None
         return int(self._weight.replace('lb', ''))
 
     @property

sportsreference/nba/roster.py

@@ -720,6 +720,8 @@ def weight(self):
         """
         Returns an ``int`` of the player's weight in pounds.
         """
+        if not self._weight:
+            return None
         return int(self._weight.replace('lb', ''))
 
     @property

sportsreference/nfl/roster.py

@@ -663,6 +663,8 @@ def weight(self):
         """
         Returns an ``int`` of the player's weight in pounds.
         """
+        if not self._weight:
+            return None
         return int(self._weight.replace('lb', ''))
 
     @property

sportsreference/nhl/roster.py

@@ -568,6 +568,8 @@ def weight(self):
         """
         Returns an ``int`` of the player's weight in pounds.
         """
+        if not self._weight:
+            return None
         return int(self._weight.replace('lb', ''))
 
     @_int_property_decorator

tests/unit/test_mlb_roster.py

@@ -84,3 +84,11 @@ def test_cleanup_of_none_returns_default_for_player(self):
         result = _cleanup_player(None)
 
         assert result == ''
+
+    @patch('requests.get', side_effect=mock_pyquery)
+    def test_missing_weight_returns_none(self, *args, **kwargs):
+        mock_weight = PropertyMock(return_value=None)
+        player = Player(None)
+        type(player)._weight = mock_weight
+
+        assert not player.weight

tests/unit/test_nba_roster.py

@@ -103,6 +103,14 @@ def test_empty_contract_is_none(self):
 
         assert player._contract is None
 
+    @patch('requests.get', side_effect=mock_pyquery)
+    def test_missing_weight_returns_none(self, *args, **kwargs):
+        mock_weight = PropertyMock(return_value=None)
+        player = Player(None)
+        type(player)._weight = mock_weight
+
+        assert not player.weight
+
 
 class TestInvalidNBAPlayer:
     def test_no_player_data_returns_no_stats(self):

tests/unit/test_nfl_roster.py

@@ -38,3 +38,11 @@ def test_invalid_url_returns_none(self, *args, **kwargs):
         result = player._retrieve_html_page()
 
         assert result is None
+
+    @patch('requests.get', side_effect=mock_pyquery)
+    def test_missing_weight_returns_none(self, *args, **kwargs):
+        mock_weight = PropertyMock(return_value=None)
+        player = Player(None)
+        type(player)._weight = mock_weight
+
+        assert not player.weight

tests/unit/test_nhl_roster.py

@@ -38,3 +38,11 @@ def test_invalid_url_returns_none(self, *args, **kwargs):
         result = player._retrieve_html_page()
 
         assert result is None
+
+    @patch('requests.get', side_effect=mock_pyquery)
+    def test_missing_weight_returns_none(self, *args, **kwargs):
+        mock_weight = PropertyMock(return_value=None)
+        player = Player(None)
+        type(player)._weight = mock_weight
+
+        assert not player.weight