Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue pulling football teams with incomplete league positions #530

Closed
roclark opened this issue Nov 13, 2020 · 0 comments · Fixed by #528
Closed

Issue pulling football teams with incomplete league positions #530

roclark opened this issue Nov 13, 2020 · 0 comments · Fixed by #528
Assignees
@roclark
Labels
bug Something isn't working
Milestone
Release 0.6.0

Comments

@roclark
Copy link
Owner

roclark commented Nov 13, 2020

Describe the bug
As seen in the exhaustive GitHub Actions test, some football teams are throwing an IndexError while attempting to pull the teams league position when it doesn't exist.

To Reproduce
See the latest GitHub Actions output for exhaustive FB tests.

Expected behavior
The default value of None should be used in the case that a value isn't parsable from a team page.

Screenshots
N/A

Desktop (please complete the following information):

  • OS: Affects All
  • Sportsreference Version: Latest upstream master

Additional context
N/A
@roclark roclark added the bug Something isn't working label Nov 13, 2020
@roclark roclark added this to the Release 0.6.0 milestone Nov 13, 2020
@roclark roclark self-assigned this Nov 13, 2020
@roclark roclark mentioned this issue Nov 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roclark roclark

Labels
bug Something isn't working
Projects
None yet
Milestone
Release 0.6.0
Development

Successfully merging a pull request may close this issue.

Fix issue pulling football league positions roclark/sportsipy
1 participant
@roclark