Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change exchange dependency in DataFeed #257

Open
ramilexe opened this issue Apr 7, 2023 · 4 comments
Open

Change exchange dependency in DataFeed #257

ramilexe opened this issue Apr 7, 2023 · 4 comments
Labels
env/core kind/improvement Refactorings, improvements and tunning

Comments

@ramilexe
Copy link
Contributor

ramilexe commented Apr 7, 2023

DataFeedSubscription accepts exchange service.Exchange but uses only CandlesSubscription method from Feeder interface. Does it make sense to change dependency from Exchange interface to Feeder?
@rodrigo-brito rodrigo-brito added kind/improvement Refactorings, improvements and tunning env/core labels Apr 7, 2023
@rodrigo-brito
Copy link
Owner

rodrigo-brito commented Apr 7, 2023 •
edited
Loading

Hi @ramilexe, thanks for the suggestion!
Of course, both will be compatible. But in theory they are internal modules, this should not affect external users, are you having any problems with this point?

@ramilexe
Copy link
Contributor Author

ramilexe commented Apr 7, 2023

yes, I would like to use future.WsCombinedKlineServe method and instead of just implementing CandlesSubscription method and some other from Feeder I also need to implement Broker methods as well.

@rodrigo-brito
Copy link
Owner

Please, can you open a PR with this change?

@ramilexe ramilexe mentioned this issue Apr 7, 2023
Closed
@ramilexe
Copy link
Contributor Author

ramilexe commented Apr 7, 2023

@rodrigo-brito here we go #258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
env/core kind/improvement Refactorings, improvements and tunning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ramilexe @rodrigo-brito