Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: typescript should be a dev dependency #16

Closed
roerohan opened this issue Oct 29, 2021 · 1 comment
Closed

bug: typescript should be a dev dependency #16

roerohan opened this issue Oct 29, 2021 · 1 comment

Comments

@roerohan
Copy link
Owner

"typescript": "^4.2.4",

Since typescript is a dependency, any project using a different version of typescript will fail to run npm install react-vnc and throw an error like the following:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! Found: typescript@4.4.4
npm ERR! node_modules/typescript
npm ERR!   typescript@"^4.0.3" from the root project
npm ERR!   typescript@"^4.2.4" from react-vnc@0.2.5
npm ERR!   node_modules/react-vnc
npm ERR!     react-vnc@"0.2.5" from the root project
@roerohan
Copy link
Owner Author

Resolved in #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant