From 0b5c75c3c74888821d9321c93ac0fb2f8998c209 Mon Sep 17 00:00:00 2001
From: sharmaashish13 <ashish.sharma@esoptra.com>
Date: Wed, 12 Jan 2022 21:35:29 +0530
Subject: [PATCH] added changelog, new method documentation and updated test

---
 CHANGELOG.md  |  3 +++
 value.go      |  3 ++-
 value_test.go | 61 ++++++++++++++++++++++++++++++++++++++-------------
 3 files changed, 51 insertions(+), 16 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 23dab97d7..6f1726a11 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+- Support for [binary strings](https://developer.mozilla.org/en-US/docs/Web/API/DOMString/Binary). `NewStringFromByteArray` takes bytes array as input and uses `String::NewFromOneByte` to convert each byte to an equivalent character.
+
 ## [v0.7.0] - 2021-12-09
 
 ### Added
diff --git a/value.go b/value.go
index dab1a6854..5bb9f88ea 100644
--- a/value.go
+++ b/value.go
@@ -53,9 +53,10 @@ func Null(iso *Isolate) *Value {
 	return iso.null
 }
 
+// NewStringFromByteArray returns V8::string from byte array. Converts each byte into equivalent character.
 func NewStringFromByteArray(iso *Isolate, val []byte) (*Value, error) {
 	if iso == nil {
-		return nil, errors.New("v8go: failed to create new Value: Isolate cannot be <nil>")
+		panic(errors.New("v8go: failed to create new Value: Isolate cannot be <nil>"))
 	}
 	cUint := (*C.uchar)(unsafe.Pointer(&val[0]))
 	rtnVal := C.NewValueStringFromByteArray(iso.ptr, cUint, C.int(len(val)))
diff --git a/value_test.go b/value_test.go
index 9abe08424..07594635e 100644
--- a/value_test.go
+++ b/value_test.go
@@ -6,7 +6,6 @@ package v8go_test
 
 import (
 	"bytes"
-	"encoding/base64"
 	"fmt"
 	"math"
 	"math/big"
@@ -476,23 +475,55 @@ func TestValueFunction(t *testing.T) {
 
 func TestNewStringFromByteArray(t *testing.T) {
 	t.Parallel()
-	ctx := v8.NewContext()
-	iso := ctx.Isolate()
-
-	inputString := "CN7ySxWjjWNpbYPB1n/TBR8avujZS2cHdXRR5ZM7Fi6QBjlVzBqPu0CI9pQXcW9fvbMXdqU+57XY/QdGozJT19+gbQDM0ZQVzjwqtpyLorcPHjMqum+7dHD6XF5cXo3NZlKGsxcnvSVyClBDU5M1dUCe8bB9yV0wVM6ge+0WAmTX2GYbncilTjDw0bSJI1Z+71NT8UQCfmimKhVxJiKrnkaTrTw2Ma/1I2w4Dny3cRlFtCtob9cvNOeeIm8HtQoi/7HXoE0uFr1C39OL2hCC1TJsxX94djtNFqd9aUOPYrwT+zErSokSvbNYS5WpEjEpRJze9+TCV9NLmqCnARK4Bw"
-	byts, _ := base64.RawStdEncoding.DecodeString(inputString)
+	iso := v8.NewIsolate()
+	defer iso.Dispose()
+	global := v8.NewObjectTemplate(iso)
+
+	testFn := v8.NewFunctionTemplate(iso, func(info *v8.FunctionCallbackInfo) *v8.Value {
+		args := info.Args()
+		input := args[0].String()
+		if len(input) == 0 {
+			//String() terminates input at null character. hence hardcoding for 3rd input
+			input = "a\x00\xffe"
+		}
+		val, _ := v8.NewStringFromByteArray(iso, []byte(input))
+		return val
+	})
+	global.Set("foo", testFn, v8.ReadOnly)
 
-	expected := "ÞòK£cimƒÁÖÓ¾èÙKgutQå“;.9Ȕ»@ˆö”qo_½³v¥>çµØýF£2S×ß m"
-	val, err := v8.NewStringFromByteArray(iso, byts)
-	if err != nil {
-		t.Errorf("expected nil but got error %#v", err)
-	}
-	if !val.IsString() {
-		t.Errorf("expected string but got %s", reflect.TypeOf(val))
+	ctx := v8.NewContext(iso, global)
+	defer ctx.Close()
+	tests := [...]struct {
+		name   string
+		script string
+	}{
+		{"normal string",
+			` 	let res = foo("str"); 
+				if(res.length != 3){
+					throw Error("expected length 3")
+				}
+			`},
+		{"multi-byte sequence",
+			` 	res = foo("Ò"); 
+				if(res.length != 2 ){
+					throw Error("expected length 2")
+				}
+			`},
+		{"null terminated sequence",
+			` 	res = foo("");
+				if(res.length != 4){
+					throw Error("expected length 4")
+				}
+			`},
 	}
-	if val.String() != expected {
-		t.Errorf("expected not same as actual")
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if _, err := ctx.RunScript(tt.script, ""); err != nil {
+				t.Errorf("expected <nil> error, but got error: %v", err)
+			}
+		})
 	}
+
 }
 
 func TestValueSameValue(t *testing.T) {